Name the smoke suite's tasks instead of filtering the cross-section

Name the smoke suite's tasks instead of filtering the cross-section

A filter that stopped matching would build an empty suite quietly. Naming the
tasks puts the failure where it belongs: pinFor throws on an id the registry
does not hold.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SoZMfWRSGnf6FZX2Ar9rQ2

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SoZMfWRSGnf6FZX2Ar9rQ2

Deploy story

What this commit did to the running system — joined from the forge receipt chain, the part a commit page elsewhere cannot show.

Not deployed through the forge lane

No push, promotion, build, or deploy receipt references this commit (receipts are scanned over a bounded recent window). Changes shipped by full node replacement carry their proof in the release gate receipt instead.

Changed files

modified bench/build-suites.mjs
modified bench/suites/smoke.suite.json

Diff

2 files changed, +11 -7

      "smoke",
      "smoke",
      "The fast lane: two quick Terminal-Bench tasks for checking that the harness, the adapter, and the lane are alive. Declared smoke, so its result is never a published score however completely it runs.",
      TB2_CROSS_SECTION.filter(
        (name) => name === "regex-log" || name === "fix-code-vulnerability",
      ).map((name) => registryTask(datasets, "terminal-bench@2.0", name, "quick-shaped", true)),
      // Named outright rather than filtered out of the cross-section: a filter
      // that matched nothing would quietly build an empty suite, and
      // `pinFor` throwing on a name the registry does not hold is the failure
      // mode this script should have.
      ["regex-log", "fix-code-vulnerability"].map((name) =>
        registryTask(datasets, "terminal-bench@2.0", name, "quick-shaped", true),
      ),
    ),
    check,
  );

  "description": "The fast lane: two quick Terminal-Bench tasks for checking that the harness, the adapter, and the lane are alive. Declared smoke, so its result is never a published score however completely it runs.",
  "tasks": [
    {
      "id": "fix-code-vulnerability",
      "id": "regex-log",
      "pin": {
        "kind": "harbor-registry",
        "dataset": "terminal-bench@2.0",
        "gitUrl": "https://github.com/laude-institute/terminal-bench-2.git",
        "commit": "69671fbaac6d67a7ef0dfec016cc38a64ef7a77c",
        "path": "fix-code-vulnerability"
        "path": "regex-log"
      },
      "environmentAvailable": true,
      "rationale": "quick-shaped"
    },
    {
      "id": "regex-log",
      "id": "fix-code-vulnerability",
      "pin": {
        "kind": "harbor-registry",
        "dataset": "terminal-bench@2.0",
        "gitUrl": "https://github.com/laude-institute/terminal-bench-2.git",
        "commit": "69671fbaac6d67a7ef0dfec016cc38a64ef7a77c",
        "path": "regex-log"
        "path": "fix-code-vulnerability"
      },
      "environmentAvailable": true,
      "rationale": "quick-shaped"

332	332		`"smoke",`
333	333		`"smoke",`
334	334		`"The fast lane: two quick Terminal-Bench tasks for checking that the harness, the adapter, and the lane are alive. Declared smoke, so its result is never a published score however completely it runs.",`
335		-	`TB2_CROSS_SECTION.filter(`
336		-	`(name) => name === "regex-log" \|\| name === "fix-code-vulnerability",`
337		-	`).map((name) => registryTask(datasets, "terminal-bench@2.0", name, "quick-shaped", true)),`
	335	+	`// Named outright rather than filtered out of the cross-section: a filter`
	336	+	`// that matched nothing would quietly build an empty suite, and`
	337	+	// `pinFor` throwing on a name the registry does not hold is the failure
	338	+	`// mode this script should have.`
	339	+	`["regex-log", "fix-code-vulnerability"].map((name) =>`
	340	+	`registryTask(datasets, "terminal-bench@2.0", name, "quick-shaped", true),`
	341	+	`),`
338	342		`),`
339	343		`check,`
340	344		`);`

5	5		`"description": "The fast lane: two quick Terminal-Bench tasks for checking that the harness, the adapter, and the lane are alive. Declared smoke, so its result is never a published score however completely it runs.",`
6	6		`"tasks": [`
7	7		`{`
8		-	`"id": "fix-code-vulnerability",`
	8	+	`"id": "regex-log",`
9	9		`"pin": {`
10	10		`"kind": "harbor-registry",`
11	11		`"dataset": "terminal-bench@2.0",`
12	12		`"gitUrl": "https://github.com/laude-institute/terminal-bench-2.git",`
13	13		`"commit": "69671fbaac6d67a7ef0dfec016cc38a64ef7a77c",`
14		-	`"path": "fix-code-vulnerability"`
	14	+	`"path": "regex-log"`
15	15		`},`
16	16		`"environmentAvailable": true,`
17	17		`"rationale": "quick-shaped"`
18	18		`},`
19	19		`{`
20		-	`"id": "regex-log",`
	20	+	`"id": "fix-code-vulnerability",`
21	21		`"pin": {`
22	22		`"kind": "harbor-registry",`
23	23		`"dataset": "terminal-bench@2.0",`
24	24		`"gitUrl": "https://github.com/laude-institute/terminal-bench-2.git",`
25	25		`"commit": "69671fbaac6d67a7ef0dfec016cc38a64ef7a77c",`
26		-	`"path": "regex-log"`
	26	+	`"path": "fix-code-vulnerability"`
27	27		`},`
28	28		`"environmentAvailable": true,`
29	29		`"rationale": "quick-shaped"`