Fail precommit on test warnings

Fail precommit on test warnings

Remove the remaining test-file warnings and run the Elixir suite with warnings treated as errors. Record the completed Gate 0 hardening in the plan.

Deploy story

What this commit did to the running system — joined from the forge receipt chain, the part a commit page elsewhere cannot show.

Not deployed through the forge lane

No push, promotion, build, or deploy receipt references this commit (receipts are scanned over a bounded recent window). Changes shipped by full node replacement carry their proof in the release gate receipt instead.

Changed files

modified docs/2026-08-20-integration-hardening-and-staging-readiness-recommendations.md
modified mix.exs
modified test/openagents/forge/mirror_watch_test.exs
modified test/openagents/roles_test.exs

Diff

4 files changed, +5 -3

- Added `npm test` in `assets/package.json` and the `mix assets.test` alias.
- Added `mix assets.test` to `mix precommit`, so the standard repository gate
  fails when browser-side voice behavior regresses.
- Removed the remaining test-compilation warnings and made
  `mix test --warnings-as-errors` part of `mix precommit`.

Gate 0 still requires the merged default and cluster coverage report, release
startup proof against a disposable database, and an exact-SHA gate receipt.

        "deps.unlock --unused",
        "format",
        "assets.test",
        "test"
        "test --warnings-as-errors"
      ]
    ]
  end

  use OpenAgents.SarahDataCase, async: false
  import Ecto.Query

  alias OpenAgents.Forge.{MirrorWatch, Pushes, Repos}
  alias OpenAgents.Forge.{MirrorWatch, Repos}
  alias OpenAgents.Repo

  setup do

  end

  test "a tampered selection cannot enter composition" do
    selection = Roles.default_selection()
    %Selection{} = selection = Roles.default_selection()

    tampered = %Selection{selection | reason: "sales_override"}


90	90		- Added `npm test` in `assets/package.json` and the `mix assets.test` alias.
91	91		- Added `mix assets.test` to `mix precommit`, so the standard repository gate
92	92		`fails when browser-side voice behavior regresses.`
	93	+	`- Removed the remaining test-compilation warnings and made`
	94	+	`mix test --warnings-as-errors` part of `mix precommit`.
93	95
94	96		`Gate 0 still requires the merged default and cluster coverage report, release`
95	97		`startup proof against a disposable database, and an exact-SHA gate receipt.`

113	113		`"deps.unlock --unused",`
114	114		`"format",`
115	115		`"assets.test",`
116		-	`"test"`
	116	+	`"test --warnings-as-errors"`
117	117		`]`
118	118		`]`
119	119		`end`

8	8		`use OpenAgents.SarahDataCase, async: false`
9	9		`import Ecto.Query`
10	10
11		-	`alias OpenAgents.Forge.{MirrorWatch, Pushes, Repos}`
	11	+	`alias OpenAgents.Forge.{MirrorWatch, Repos}`
12	12		`alias OpenAgents.Repo`
13	13
14	14		`setup do`

130	130		`end`
131	131
132	132		`test "a tampered selection cannot enter composition" do`
133		-	`selection = Roles.default_selection()`
	133	+	`%Selection{} = selection = Roles.default_selection()`
134	134
135	135		`tampered = %Selection{selection \| reason: "sales_override"}`
136	136