Sidebar labels stop losing their descenders, and the mark grows

6d3f45b00ba3 · AtlantisPleb · · parent 585a029cb9ae

Sidebar labels stop losing their descenders, and the mark grows

`.sidebar-row__label` carries `overflow: hidden` so its text can ellipsis, and
that also makes the span a block whose height is exactly its line box. At the
row's 20px line height the box ended on the baseline's shoulder, so the tails
of g, j, p, q and y were sliced off. The line box gets 4px more to sit in; the
row's height comes from `min-height`, so nothing else moves.

The favicon in the docs and component shells goes from 20px to 24px, with the
intrinsic size on the element matched so it is not resampled.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0149rBWy7br1Z7bbz9NrQhEr
Co-Authored-By
Claude Opus 5 (1M context) <noreply@anthropic.com>

Deploy story

What this commit did to the running system — joined from the forge receipt chain, the part a commit page elsewhere cannot show.

Not deployed through the forge lane

No push, promotion, build, or deploy receipt references this commit (receipts are scanned over a bounded recent window). Changes shipped by full node replacement carry their proof in the release gate receipt instead.

Changed files

  • modified assets/css/app.css
  • modified assets/css/openagents.css
  • modified lib/openagents_web/components/layouts.ex

Diff

3 files changed, +10 -4

assets/css/app.css modified +6

@@ -363,7 +363,13 @@

363 363
}
364 364
365 365
.sidebar-row__label {
366
  /* `overflow: hidden` is what makes the ellipsis work, and it also makes this
367
     span a block whose height is exactly its line box. At the row's 20px line
368
     height that box ends on the baseline's shoulder, so the tails of g, j, p,
369
     q and y were sliced off. The line box gets 4px more to sit in; the row's
370
     own height is set by `min-height`, so nothing moves. */
366 371
  overflow: hidden;
372
  line-height: 1.5rem;
367 373
  white-space: nowrap;
368 374
  text-overflow: ellipsis;
369 375
}
assets/css/openagents.css modified +3 -3

@@ -5174,8 +5174,8 @@

5174 5174
     ("OpenAgents | Docs") and the section name is the useful half. */
5175 5175
  .sidebar-brand__mark img {
5176 5176
    display: block;
5177
    width: 20px;
5178
    height: 20px;
5179
    border-radius: 4px;
5177
    width: 24px;
5178
    height: 24px;
5179
    border-radius: 5px;
5180 5180
  }
5181 5181
}
lib/openagents_web/components/layouts.ex modified +1 -1

@@ -185,7 +185,7 @@ defmodule OpenAgentsWeb.Layouts do

185 185
    ~H"""
186 186
    <header class="sidebar-brand">
187 187
      <.link navigate={~p"/"} class="sidebar-brand__mark" aria-label="OpenAgents home">
188
        <img src={~p"/favicon-32x32.png"} alt="" width="20" height="20" />
188
        <img src={~p"/favicon-32x32.png"} alt="" width="24" height="24" />
189 189
      </.link>
190 190
      <span :if={@title} class="sidebar-brand__divider" aria-hidden="true"></span>
191 191
      <.link :if={@title} patch={@path} class="sidebar-brand__title">{@title}</.link>

This page updates live while a promote is in flight · changelog