OpenAgents

Commit

Add allowed-origins, orphaned controller routes, and the controller socket.

6b5e9c4ae2a0 · AtlantisPleb · · parent c2164a6ee52d 

Add allowed-origins, orphaned controller routes, and the controller socket.

- Adds OpenAgentsWeb.AllowedOrigins for CORS origin validation.
- Wires the controller socket at /controller.
- Routes the changelog, status, memory export, data export, computer,
  computer-agent job, and git forge endpoints.
- Removes the admin recording audio route and controller because no audio
  recordings are saved.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By
Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

Deploy story

What this commit did to the running system — joined from the forge receipt chain, the part a commit page elsewhere cannot show.

Not deployed through the forge lane

No push, promotion, build, or deploy receipt references this commit (receipts are scanned over a bounded recent window). Changes shipped by full node replacement carry their proof in the release gate receipt instead.

Changed files

  • added lib/openagents_web/allowed_origins.ex
  • deleted lib/openagents_web/controllers/admin_recording_controller.ex
  • modified lib/openagents_web/endpoint.ex
  • modified lib/openagents_web/router.ex

Diff

4 files changed, +76 -73

lib/openagents_web/allowed_origins.ex added +54

@@ -0,0 +1,54 @@

1 
defmodule OpenAgentsWeb.AllowedOrigins do
2 
  @moduledoc """
3 
  Validates and normalizes the CORS/check origin allow-list for production.
4
5 
  The primary host is always allowed. The optional alias list comes from a
6 
  comma-separated environment string and is intended for Cloud Run generated
7 
  URLs.
8 
  """
9
10 
  @primary_scheme "https"
11
12 
  @doc """
13 
  Returns a list of allowed origins for production.
14
15 
  `primary_host` is the canonical host (e.g. `stage.openagents.com`); it is
16 
  always returned as `https://` first. `aliases` is a comma-separated string
17 
  of `https://` origins. Each alias is validated: it must use `https` and
18 
  must not contain a path.
19 
  """
20 
  @spec for_production(String.t(), String.t()) :: [String.t()]
21 
  def for_production(primary_host, aliases) when is_binary(primary_host) do
22 
    primary = "#{@primary_scheme}://#{primary_host}"
23
24 
    parsed_aliases =
25 
      aliases
26 
      |> String.split(",")
27 
      |> Enum.map(&String.trim/1)
28 
      |> Enum.reject(&(&1 == ""))
29 
      |> Enum.map(&validate_origin!/1)
30 
      |> Enum.reject(&(&1 == primary))
31
32 
    [primary | parsed_aliases]
33 
  end
34
35 
  defp validate_origin!(""), do: raise(ArgumentError, "origin cannot be empty")
36
37 
  defp validate_origin!(origin) do
38 
    uri = URI.parse(origin)
39
40 
    cond do
41 
      uri.scheme != "https" ->
42 
        raise ArgumentError, "origin must use https: #{origin}"
43
44 
      not is_nil(uri.path) and uri.path != "" ->
45 
        raise ArgumentError, "origin must not contain a path: #{origin}"
46
47 
      is_nil(uri.host) or uri.host == "" ->
48 
        raise ArgumentError, "origin must include a host: #{origin}"
49
50 
      true ->
51 
        origin
52 
    end
53 
  end
54 
end
lib/openagents_web/controllers/admin_recording_controller.ex deleted -73

@@ -1,73 +0,0 @@

1 
defmodule OpenAgentsWeb.AdminRecordingController do
2 
  @moduledoc """
3 
  Streams one call recording to the operator.
4
5 
  ## Why there is no `Range` support
6
7 
  A WebM/Opus (or fragmented MP4) recording is only media as the ordered
8 
  concatenation of its slices: the header lives in the first slice and every
9 
  later one depends on it. Serving an arbitrary byte range would hand a browser
10 
  something that is not a valid stream, and computing real ranges means unsealing
11 
  and measuring every chunk first — which is a scan, not a seek.
12
13 
  So this reader advertises `accept-ranges: none` and streams the whole thing.
14 
  The visible cost is that the operator can play and pause but cannot scrub, and
15 
  Safari may decline to play a range-less stream at all. That is a deliberate,
16 
  documented v1 limit rather than an oversight; `docs/voice/RECORDINGS.md` records
17 
  what fixing it would take.
18 
  """
19
20 
  use OpenAgentsWeb, :controller
21
22 
  import Plug.Conn
23
24 
  alias OpenAgents.Admin
25 
  alias OpenAgents.Repo
26 
  alias OpenAgents.Voice.Recordings
27
28 
  def show(conn, %{"id" => id}) do
29 
    case Admin.get_recording(id) do
30 
      {:ok, recording, _owner} ->
31 
        if recording.chunk_count > 0 and
32 
             recording.status in OpenAgents.Voice.Recording.playable_statuses() do
33 
          stream_recording(conn, recording)
34 
        else
35 
          send_resp(conn, :not_found, "")
36 
        end
37
38 
      {:error, :not_found} ->
39 
        send_resp(conn, :not_found, "")
40 
    end
41 
  end
42
43 
  defp stream_recording(conn, recording) do
44 
    conn =
45 
      conn
46 
      # No charset: this is binary media, not text in an encoding.
47 
      |> put_resp_content_type(Recordings.content_type(recording), nil)
48 
      |> put_resp_header("cache-control", "no-store")
49 
      |> put_resp_header("accept-ranges", "none")
50 
      |> put_resp_header("content-disposition", "inline")
51 
      |> put_resp_header("x-content-type-options", "nosniff")
52 
      |> send_chunked(:ok)
53
54 
    # Repo.stream needs a transaction, and the chunks are unsealed one slice at a
55 
    # time so a long call never lands in memory whole.
56 
    {:ok, final_conn} =
57 
      Repo.transaction(
58 
        fn ->
59 
          recording
60 
          |> Recordings.stream()
61 
          |> Enum.reduce_while(conn, fn slice, current_conn ->
62 
            case chunk(current_conn, slice) do
63 
              {:ok, next_conn} -> {:cont, next_conn}
64 
              {:error, :closed} -> {:halt, current_conn}
65 
            end
66 
          end)
67 
        end,
68 
        timeout: :infinity
69 
      )
70
71 
    final_conn
72 
  end
73 
end
lib/openagents_web/endpoint.ex modified +4

@@ -15,6 +15,10 @@ defmodule OpenAgentsWeb.Endpoint do

15 15 
    websocket: [connect_info: [session: @session_options]],
16 16 
    longpoll: [connect_info: [session: @session_options]]
17 17
18 
  socket "/controller", OpenAgentsWeb.ControllerSocket,
19 
    websocket: [connect_info: [session: @session_options]],
20 
    longpoll: [connect_info: [session: @session_options]]
21
18 22 
  # Serve at "/" the static files from "priv/static" directory.
19 23 
  #
20 24 
  # When code reloading is disabled (e.g., in production),
lib/openagents_web/router.ex modified +18

@@ -68,8 +68,26 @@ defmodule OpenAgentsWeb.Router do

68 68 
    post "/voice/calls/recording", VoiceRecordingController, :create
69 69 
    post "/voice/calls/recording/complete", VoiceRecordingController, :complete
70 70 
    delete "/voice/calls", VoiceCallController, :delete
71
72 
    get "/data/export", DataController, :show
73 
    get "/data/export/atif", DataController, :export_atif
74 
    delete "/data", DataController, :delete
75 
    delete "/data/reset", DataController, :reset
76
77 
    get "/api/computers", ComputersController, :index
78 
    post "/api/computers/pairings/:id/approve", ComputersController, :approve_pairing
79 
    delete "/api/computers/:id", ComputersController, :delete
80 
    post "/api/computers/:machine_id/agent-jobs", ComputerAgentJobsController, :create
81 
    get "/api/computer-agent-jobs/:id", ComputerAgentJobsController, :show
82 
    delete "/api/computer-agent-jobs/:id", ComputerAgentJobsController, :delete
83
84 
    get "/api/changelog", ChangelogController, :show
85 
    get "/api/status", NetworkStatusController, :show
86 
    get "/memory/export", MemoryExportController, :show
71 87 
  end
72 88
89 
  forward "/git", OpenAgents.Forge.GitHTTP
90
73 91 
  scope "/api/v3", OpenAgentsWeb do
74 92 
    pipe_through :api
75 93

This page updates live while a promote is in flight · changelog